So uh…will it not be helpful for me to also post my skills.log output?
You know what they say about the guy who’s two steps behind…he has…a lot of catching up to do. This is fun though, usually I’m the fastest guy in the room when I do my sort of programming.
Oh, I’m aware of the remove option, but there’s no way to force removal of a given instance if there are identically-named skills, which apparently happened.
[Edit] Obviously, in normal circumstances, it shouldn’t happen at all.
I did, yes. It didn’t seem to really do anything, just printed a message that it switched to that branch.
(.venv) pi@picroft:/opt/mycroft/skills/skill-homeassistant.tony763 $ git checkout patch-8
Already on 'patch-8'
Your branch is up to date with 'origin/patch-8'.
(.venv) pi@picroft:/opt/mycroft/skills/skill-homeassistant.tony763 $
Do I need to make it update itself after I do this?
perfect, you do not have empty sting but nonetype. Two instances with same version of skill and two different errors. Thanks, I will let you know when I make fix.
Hey there, I thought I’d respond to you here instead of making a new thread, but I can break this out to a separate thread if you’d like…
Referencing this conversation: I was also having this issue of not being able to dim the lights, and I just reinstalled the homeassistant skill because I saw you had fixed it, and now I can set dimmer levels on lights! So that’s awesome.
I was wondering a few things:
Is there work going on so that the feedback doesn’t specify tenths of units? For instance, if I ask Mycroft for a lighting level of 50 percent, it sets it, then speaks the confirmation “Successfully set %entity to fifty point zero percent.” I’d change this myself, if I knew where in the code to look. I’m a professional lighting designer and even I don’t work in tenths of percents.
I feel accessing this part of the skill is a bit clumsy, word-wise. For instance, with Siri, commands to set levels can be formatted thusly: “Set the floor lamp to 50%”, and the change happens. Without knowing how the voice commands work, is that sort of fuzzy matching possible? Can a skill be written such that it passes along a request for a percent or a unit, and if it makes sense, the entity sets itself to that?
Just some thoughts…and thank you, sincerely, for all your hard work making this skill one of the most useful in all of the marketplace. Except the cocktails one.
it’s only about format of variable holding level percentage. Now it’s float so , numbers after dot is spoken, this should be easy change and it should be accepted without a problem.
Now it’s “set brightness floor lamp to 50%”, we can switch words to be less clumsy but I would not recommend removing brightness from sentence. Each sentence/function need to be unique as much as possible as it could collide with other skills functions or worse with other skills. For HA skill it happened with where is skill, and it took me a really long time to overcome it.
We could try to do same thing as I did with conflicted where is skill. Register each entity only with a functions/utterances with it can interact. But for now, it would bring a really big overhaul to padatious intent engine and stopped it from function. I tried it, was not nice, only reset solved. So Yes, maybe in the future, but not now.