Mycroft speaks twice with HomeAssistant confirmations

perfect, you do not have empty sting but nonetype. Two instances with same version of skill and two different errors. Thanks, I will let you know when I make fix.

1 Like

Done, test this branch: git fetch && git checkout feature/issue86x2

error: pathspec 'issue86x2' did not match any file(s) known to git

Perhaps I’m doing something wrong?

my bad, I edited the post above

Branch 'feature/issue86x2' set up to track remote branch 'feature/issue86x2' from 'origin'.
Switched to a new branch 'feature/issue86x2'

rebooting, let’s see how this goes…

Well, that did something, because now she won’t shut up about the HomeAssistant’s IP address. Adding long-term access token, setting the hostname…

Hooray, it works! :heart_eyes:

It will also set the thermostat correctly, doesn’t say “none” at the end, and only says it once. So groovy! Thank you very much for your fix / help!

[Edit] I’m going to re-enable the disabled thermostat entities to see if that’s still an issue, and I will report back.

1 Like

Glad it works, let me know.

1 Like

Hey there, I thought I’d respond to you here instead of making a new thread, but I can break this out to a separate thread if you’d like…

Referencing this conversation: I was also having this issue of not being able to dim the lights, and I just reinstalled the homeassistant skill because I saw you had fixed it, and now I can set dimmer levels on lights! So that’s awesome. :heart_eyes:

I was wondering a few things:

  1. Is there work going on so that the feedback doesn’t specify tenths of units? For instance, if I ask Mycroft for a lighting level of 50 percent, it sets it, then speaks the confirmation “Successfully set %entity to fifty point zero percent.” I’d change this myself, if I knew where in the code to look. I’m a professional lighting designer and even I don’t work in tenths of percents.

  2. I feel accessing this part of the skill is a bit clumsy, word-wise. For instance, with Siri, commands to set levels can be formatted thusly: “Set the floor lamp to 50%”, and the change happens. Without knowing how the voice commands work, is that sort of fuzzy matching possible? Can a skill be written such that it passes along a request for a percent or a unit, and if it makes sense, the entity sets itself to that?

Just some thoughts…and thank you, sincerely, for all your hard work making this skill one of the most useful in all of the marketplace. Except the cocktails one. :cocktail:

Hi @sparkyvision,

  1. it’s only about format of variable holding level percentage. Now it’s float so , numbers after dot is spoken, this should be easy change and it should be accepted without a problem.

  2. Now it’s “set brightness floor lamp to 50%”, we can switch words to be less clumsy but I would not recommend removing brightness from sentence. Each sentence/function need to be unique as much as possible as it could collide with other skills functions or worse with other skills. For HA skill it happened with where is skill, and it took me a really long time to overcome it.

We could try to do same thing as I did with conflicted where is skill. Register each entity only with a functions/utterances with it can interact. But for now, it would bring a really big overhaul to padatious intent engine and stopped it from function. I tried it, was not nice, only reset solved. :slight_smile: So Yes, maybe in the future, but not now.

Now it’s “set brightness floor lamp to 50%”, we can switch words to be less clumsy but I would not recommend removing brightness from sentence.

I wonder about if the sentence includes an entity name that is a light / dimmer type, HA could make an assumption? But I do see your point! Thanks for replying.

Now it’s float so

I know this refers to “types” of numbers in programming, but I have no understanding beyond that. I’ll take your word for it. :stuck_out_tongue:

It’s not about HA but more about Mycroft and Padatious engine itself. :wink:

Hmm, well…after reading up on Padatious and intents, I might try doing some minor edits inside the HA skill so I can talk to the computer in my preferred word order. I’ll report back how things go!

[edit: feature request: can I ask for temperatures for my thermostat in Kelvin and / or Rankine?]

[edit 2: the above edit was a joke]

1 Like

[edit 3: doing it anyway!]

1 Like

I’m a loner, Baconator. A rebel.

1 Like