gez-mycroft’s suggestion over on github simplifies installing the skill. I added a requirements.txt file with the fuzzywuzzy dependency. So now you only need to issue the following command to install the skill…
Thanks for your work , installation worked like a charm.
CPS_match_query on the other hand, has me pretty puzzled it never finds what i’m asking for.
Sometimes it doesn’t start music because it thinks stuff is not in my library …
rhythmbox-skill_dwfalk - INFO - Artist Utterance: eminem
Playback Control Skill - INFO - No matches
rhythmbox-skill_dwfalk - INFO - Artist Probabilities: (‘Eminem’, 100)
And it doesn’t do anything else… I am sure it should work ,
do you have any insights about the common play skill skill class?
i am trying to use it in my own music skill and i am also having problems adapting it to common play is it me using it wrong ? thank you again have a nice day
colla69…If you wish, you can open an issue over on the github site I reference for skill feedback and post the pertinent contents of your Rhythmbox database (~/.local/share/rhythmbox/rhythmdb.xml) and I’ll take a peek.
You can also look at my code on the github site to get an idea on how to work with common play skill. I was a little intimidated with it myself, at first. But took on the challenge of converting my original code to it and am rather happy I did.
Hey @dwfalk…
i found out what the problem is … it has notihg to do with your skill …
The common play framework has a timeout, you should be getting an answer from the search queries in max 1 sec time…
thats why i got
“Playback Control Skill - INFO - No matches”
before
“rhythmbox-skill_dwfalk - INFO - Artist Probabilities: (‘Eminem’, 100)”
My computer isn’t fast enough (it’s getting old ^^ and my rhythmdb.xml is almost 20 MB and increasing )…
That meand Your Skill passed all my tests on a smaller library… all the problems i had seem to arise because of the performance of my pc…
At the moment I am trying to write a Filecrawler that can load my data faster hoping i can structure the data to speed up the search… I’ll be developing a test version for my own player skill. If your intrested I’ll let you know when i have something working…
nice ability. I have found that the complete request is always sent to playlist, artist and title. “Hells Bells by AC DC” instead of “Hells Bells” and artist “AC DC”. Normally, the mycroft player module can separate this. I use German. how is that with you? Maybe my translation in the mycroft player module is not correct either.
I had in mind to add “song by artist” to the skill. Its been a while since I tinkered around. I appreciate the feedback. It’ll stir me to get back to doing some coding. Guten Tag!
Thanks for the suggestion. This was a hobby project of mine. I’m not the most literate on the ins and outs of Python and XML, having just a basic programming background. A Google search is leading me in the direction of lxml, interparse, and using element.clear. But I am open to any recommendations.
I opened an issue over on the skill’s github site to track benchmarking alternative xml logic. I’ll use it to comment on any progress or potential avenues in supporting larger Rhythmbox databases. Please feel free to visit and leave comments as well on any suggestions you might have regarding the efficient processing of the Rhythmbox xml databases. Regards.
I’m now caching the Rhythmbox xml database in skill class list variables. The first time accessing the skill, it will cause the cache to be built. Subsequent calls to the skill will use the cache. Hopefully that will help individuals with large Rhythmbox databases.
The skill goes right for songs / artists.
Might I suggest to add a command like “play album **” maybe with possibility to specify artist (“play album XX by artst XX”)?
Thanks for the suggestion “docjuhnk”. I’ve added album and album by logic. I want to be careful not to weigh down the speed of the skill. But I kinda anticipated this request and can see where it would be handy.
I really appreciate everyone that uses the skill. Its nice to be able to contribute something to the open source community and to the potential that Mycroft exhibits.
Works like a charm!
I can’t really say, that it has slowed my installation. (I have a little over 5k tracks / 460 Albums / 270 interprets in my database.)
Thanks for your quick reply and updating the skill.