I would remve setting to s it isnt needed. Unless you would have posibility to set language different than the languge mycroft uses.
You could check if language mycroft uses is a language that tmdb supports - and if not fall back to English or tell the user that skill dosnt support that language.
It seems like therre are mising a check if description is missing from results. If I ask for what some movie is about, and there isnt a description he just says
"the movie {movie} is about this. " but never says more than that
I think it is because description/overvievis empty.
notice I am testing using Danish, and some movies dosnt have Danish descriptions, so maybe it isnt a problem in English…But implementing a check if overviev is empty and handle that could be a good idea.
I am not having that issue. The issue that I am having is that with the online mimic2 voice, only the last sentence is played. If I change the voice, it works fine. Don’t get that one. And, it only happens when it plays the overview. Just basic info, it plays fine.
I believe that I do have error checking there, but maybe it is to general. It just checks for a valid movieID and if it returns an IndexError, it cannot find the movie.
check this by:
“Hey Mycroft. Tell me about the movie kljfdsajkfdsaj”
Should return:
“I can not find any information on the movie kljfdsajkfdsaj”
@andlo, thank you so much for you input. These things have been implemented and other fixes around multiple answers such as genres and cast members have been made more human sounding.
I hope this skill is useful to someone. I will be adding to it soon.
First you add a little more to the readme.md
a category like
## Category
**Information**
and maybe also some tags ike
## Tags
#movie
#themoviedb
#cinema
#entertaiment
Also maybe add some more information on how to obtain the API key
then maybe some more replying positive back on this thred also would be nice.
and then comes the “go to market” stuf……
In the skillsdir you run
msk submit .
(notise the dot to use current directory)
and follow the guide. Then it will dd the PR to the mycroft-skils-repo and then the testers will ook at it and reply throu GitHub. And when everything is fine it will be merged and it is on the market
Later when you have changes you do msk submit . again and there will be made another PR with the the updates. and same procedure follows.
When translations comes from trnslate.mycroft.ai, you will get PR’s at GitHub and you can merge those.